Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable rgb underglow for VIA-firmware #11746

Merged
merged 1 commit into from
Feb 19, 2021
Merged

enable rgb underglow for VIA-firmware #11746

merged 1 commit into from
Feb 19, 2021

Conversation

4pplet
Copy link
Contributor

@4pplet 4pplet commented Jan 31, 2021

Setting rgb underglow enabled by default for VIA firmware

Description

Setting rgb underglow enabled by default for VIA firmware

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

No rgb underglow function in precompiled via hex.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Jan 31, 2021
@spidey3
Copy link
Contributor

spidey3 commented Feb 17, 2021

Perhaps RGBLIGHT_ENABLE = yes should be in keyboards/4pplet/aekiso60/rev_a/rules.mk and keyboards/4pplet/steezy60/rev_a/rules.mk, if both keyboards support RGB underglow as a regular feature...

@spidey3 spidey3 self-requested a review February 17, 2021 22:36
@4pplet
Copy link
Contributor Author

4pplet commented Feb 17, 2021

Perhaps RGBLIGHT_ENABLE = yes should be in keyboards/4pplet/aekiso60/rev_a/rules.mk and keyboards/4pplet/steezy60/rev_a/rules.mk, if both keyboards support RGB underglow as a regular feature...

I would prefer it like this, you can easily enable underglow in the rules if building QMK. There is no keycodes to turn off underglow etc in the default keymap so I'd argue it makes sense. For VIA on the other hand, the feature need to be enabled. :)

@spidey3 spidey3 merged commit fd6f7b5 into qmk:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants