LED Matrix: add led_matrix_types.h and implement g_led_config #11741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First part of LED Matrix revival. Since there are no animations defined, I can only test that it compiles successfully.
Some notes:
I had to rename the EEPROM config struct
led_config_t
(RGB Matrix equivalentrgb_config_t
) toled_eeconfig_t
as otherwise it would conflict with theled_config_t
ofg_led_config
s. IMO this should be done for RGB Matrix as well, though there is no conflict there.clueboard/66_hotswap/gen1
is currently the only consumer of LED Matrix (terrazzo
also uses it but seems to have its own animation system). @skullydazed would you mind checking if theg_led_config
I've created matches the board?I copied over the (currently unused) flags defines, but omitted the underglow one - wondering if this could still be useful for boards with single-colour underglow (I don't know of any, though).
Types of Changes
Issues Fixed or Closed by This PR
Checklist