Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED Matrix: add led_matrix_types.h and implement g_led_config #11741

Merged
merged 4 commits into from
Feb 14, 2021

Conversation

fauxpark
Copy link
Member

Description

First part of LED Matrix revival. Since there are no animations defined, I can only test that it compiles successfully.

Some notes:

I had to rename the EEPROM config struct led_config_t (RGB Matrix equivalent rgb_config_t) to led_eeconfig_t as otherwise it would conflict with the led_config_t of g_led_configs. IMO this should be done for RGB Matrix as well, though there is no conflict there.

clueboard/66_hotswap/gen1 is currently the only consumer of LED Matrix (terrazzo also uses it but seems to have its own animation system). @skullydazed would you mind checking if the g_led_config I've created matches the board?

I copied over the (currently unused) flags defines, but omitted the underglow one - wondering if this could still be useful for boards with single-colour underglow (I don't know of any, though).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc merged commit 7ce5ba6 into qmk:master Feb 14, 2021
@fauxpark fauxpark deleted the led-matrix-types branch February 14, 2021 01:16
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
)

* LED Matrix: add led_matrix_types.h and implement g_led_config

* Set correct flags for non-"modifier" LEDs

* Clean up docs a little

* Add license headers for [led,rgb]_matrix_types.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants