Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sowbug/68keys and sowbug/ansi_tkl #11589

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Add sowbug/68keys and sowbug/ansi_tkl #11589

merged 5 commits into from
Feb 10, 2021

Conversation

sowbug
Copy link
Contributor

@sowbug sowbug commented Jan 17, 2021

Description

Adds two new Blue Pill-based keyboards using reasonably common layouts (Magicforce 68 and ANSI tenkeyless), with
USB-C, optional Kailh hotswap sockets, per-key RGB lighting. Both keyboards have been built as prototypes.

These keyboards were generated with the help of https://github.com/sowbug/keycad.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

I read https://beta.docs.qmk.fm/developing-qmk/c-development/hardware_keyboard_guidelines and believe this PR complies.

keyboards/sowbug/68keys/68keys.c Show resolved Hide resolved
keyboards/sowbug/68keys/68keys.c Outdated Show resolved Hide resolved
keyboards/sowbug/68keys/68keys.c Show resolved Hide resolved
keyboards/sowbug/68keys/68keys.c Show resolved Hide resolved
keyboards/sowbug/68keys/68keys.c Outdated Show resolved Hide resolved
keyboards/sowbug/68keys/config.h Outdated Show resolved Hide resolved
keyboards/sowbug/68keys/config.h Outdated Show resolved Hide resolved
keyboards/sowbug/68keys/info.json Outdated Show resolved Hide resolved
keyboards/sowbug/68keys/readme.md Outdated Show resolved Hide resolved
@sowbug
Copy link
Contributor Author

sowbug commented Jan 20, 2021

All comments addressed. Please re-review. Thanks!

@sowbug sowbug requested a review from drashna January 21, 2021 02:27
@sowbug
Copy link
Contributor Author

sowbug commented Jan 25, 2021

Thank you for the approval, @drashna. How do I get the upstream merge to happen? Is there anything else I need to do on my end?

@drashna
Copy link
Member

drashna commented Feb 10, 2021

Thanks

@drashna drashna merged commit 872f656 into qmk:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants