Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Helen 80 matrix mapping #11585

Merged
merged 1 commit into from
Feb 10, 2021
Merged

fix Helen 80 matrix mapping #11585

merged 1 commit into from
Feb 10, 2021

Conversation

LSChyi
Copy link
Contributor

@LSChyi LSChyi commented Jan 17, 2021

Fix matrix macro mapping in Helen 80.

Description

Fix macro expand of LAYOUT_tkl_ansi in Helen 80

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

spidey3
spidey3 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but perhaps @yj7272098 may want to comment before this is merged...

@spidey3 spidey3 requested a review from a team February 10, 2021 01:24
noroadsleft
noroadsleft approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft
Copy link
Member

noroadsleft commented Feb 10, 2021 •
edited
Loading

Play Keyboard's site includes a link to a Google Drive folder (through bit.ly) that includes the VIA-format JSON file. Checked it out, and according to that JSON file, the original matrix submitted to QMK was wrong.

image

@noroadsleft noroadsleft merged commit fb9f619 into qmk:master Feb 10, 2021
@noroadsleft
Copy link
Member

Thanks!

@LSChyi
Copy link
Contributor Author

LSChyi commented Feb 10, 2021 •
edited
Loading

Thank you! @yj7272098 and I are friends and he is not familiar with git and c language, so I helped him to fix some issues.

sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 10, 2021
@LSChyi @sowbug
Play Keyboard Helen 80: fix matrix mapping (qmk#11585)
c2ba56a
@LIParadise LIParadise mentioned this pull request Feb 21, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LSChyi @noroadsleft @spidey3