Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handwired/freoduo: define RGBLight config at keyboard level #11491

Merged
merged 1 commit into from
Jan 10, 2021
Merged

handwired/freoduo: define RGBLight config at keyboard level #11491

merged 1 commit into from
Jan 10, 2021

Conversation

noroadsleft
Copy link
Member

Description

Configurator compiles fail without the number of LEDs defined here. Included the rest to match the default keymap's settings.

cc @FilipParyz

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
freoduo: define RGBLight config at keyboard level
b15143f 
Configurator compiles fail without the number of LEDs defined here. Included the rest to match the default keymap's settings.
@noroadsleft noroadsleft requested a review from a team January 9, 2021 22:35
@drashna drashna requested a review from a team January 10, 2021 03:29
FilipParyz
FilipParyz approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@FilipParyz FilipParyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@zvecr zvecr merged commit 46b3245 into qmk:master Jan 10, 2021
@noroadsleft noroadsleft deleted the cf/hw_freoduo branch January 10, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@FilipParyz FilipParyz FilipParyz approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noroadsleft @drashna @FilipParyz @zvecr