Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for the Torn keyboard #11268

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Improvements for the Torn keyboard #11268

merged 3 commits into from
Jan 14, 2021

Conversation

rtitmuss
Copy link
Contributor

Description

Add bongocat animation for the oled.
Fix compiling firmware with QMK Configurator.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Richard Titmuss added 3 commits December 21, 2020 17:53
Add bongo cat animation
168792f
Map all keys on base layer
9c967e9 
... to make it easier to test newly built keyboards. The encoders
are optional and can be placed in different locations.
Fix Torn in QMK configurator
f2b9aee 
This removes additional variables defined in the keymap.c file, so
that the default firmware can be compiled by the configurator.
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 21, 2020
@rtitmuss
Copy link
Contributor Author

Bumping, hoping for another reviewer. Thanks :)

@drashna drashna requested a review from a team January 11, 2021 18:40
@drashna drashna merged commit 523c831 into qmk:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtitmuss @drashna @fauxpark