Add Launch Pad by Ungodly Design #10952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace gldcfont.c file with image byte arrays
drashna
reviewed
Nov 17, 2020
drashna
requested changes
Nov 17, 2020
Co-authored-by: Drashna Jaelre <drashna@live.com>
|
Travis complaining about firmware size but local build shows:
|
|
Yup, that's a known issue. Travis uses an older version of avr-gcc, and it compiles larger. If you're concerned, you can add the following to your rules.mk, and it may help: SPACE_CADET_ENABLE = no
MAGIC_ENABLE = no
GRAVE_ESC_ENABLE = noThis may save you on a chunk of firmware space, as well. Also removing the locking key defines helps. |
fauxpark
requested changes
Nov 18, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
Erovia
requested changes
Nov 18, 2020
Add instructions to reset bootloader
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Implement use of layer_state_set_user
fauxpark
approved these changes
Nov 19, 2020
Erovia
approved these changes
Nov 19, 2020
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist