Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new keyboard - nack #10940

Merged
merged 11 commits into from
Nov 18, 2020
Merged

Added new keyboard - nack #10940

merged 11 commits into from
Nov 18, 2020

Conversation

farfalleflickan
Copy link
Contributor

@farfalleflickan farfalleflickan commented Nov 13, 2020

Description

I've added my keyboard, as simple as that.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

I've tried my best to make sure it's all up to spec, hopefully I didn't miss anything :)

keyboards/nack/config.h Outdated Show resolved Hide resolved
keyboards/nack/config.h Outdated Show resolved Hide resolved
keyboards/nack/config.h Outdated Show resolved Hide resolved
keyboards/nack/config.h Outdated Show resolved Hide resolved
keyboards/nack/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nack/keymaps/default/keymap.h Outdated Show resolved Hide resolved
keyboards/nack/keymaps/pastapojken/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 17, 2020 02:23
@farfalleflickan farfalleflickan requested review from drashna and removed request for a team November 17, 2020 16:53
keyboards/nack/config.h Outdated Show resolved Hide resolved
keyboards/nack/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nack/keymaps/default/keymap.h Outdated Show resolved Hide resolved
keyboards/nack/readme.md Show resolved Hide resolved
@Erovia Erovia requested a review from a team November 17, 2020 19:18
keyboards/nack/info.json Outdated Show resolved Hide resolved
keyboards/nack/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nack/keymaps/pastapojken/keymap.c Outdated Show resolved Hide resolved
keyboards/nack/readme.md Outdated Show resolved Hide resolved
keyboards/nack/rules.mk Outdated Show resolved Hide resolved
Co-authored-by: Ryan <fauxpark@gmail.com>
@Erovia Erovia merged commit ad5cbe5 into qmk:master Nov 18, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants