Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of lsusb behaviour #10903

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Fix documentation of lsusb behaviour #10903

merged 1 commit into from
Jan 11, 2021

Conversation

Crote
Copy link

@Crote Crote commented Nov 9, 2020

The documentation did not accurately reflect the behaviour of lsusb , which might result in minor confusion.

Description

On Fedora 32 (and I assume most other distributions), lsusb will display the configured MANUFACTURER and PRODUCT if the database does not contain entries for the VENDOR_ID and PRODUCT_ID used. Considering the DB does not contain any entries for the vendor 0xFEED, it should just display the values as advertised by the device.

Similarly, doing a lsusb -v will not show those values, as it seems that a regular user does not have the required permissions to read them. It will just leave the field empty. Doing a sudo lsusb -v fixes this.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

Most don't apply because it's just a two-line documentation fix.

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Dec 6, 2020

This needs to be rebased.

@Crote
Copy link
Author

Crote commented Dec 8, 2020

It has been rebased.

@drashna drashna requested a review from a team December 17, 2020 05:10
@Erovia Erovia changed the base branch from develop to master December 23, 2020 17:09
@Erovia Erovia changed the base branch from master to develop December 23, 2020 17:09
@Erovia
Copy link
Member

Erovia commented Dec 23, 2020

I think you can safely target the master branch with this change as it is not breaking.
The change needs to be properly rebased first, though.

@Crote Crote changed the base branch from develop to master January 8, 2021 23:58
@Crote
Copy link
Author

Crote commented Jan 9, 2021

Retargeted & rebased

@drashna drashna merged commit efbaf68 into qmk:master Jan 11, 2021
@Crote Crote deleted the lsusb-docs branch February 2, 2021 01:11
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants