Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XD68: add 65_ansi_split_bs layuout #10835

Merged
merged 3 commits into from
Nov 10, 2020
Merged

XD68: add 65_ansi_split_bs layuout #10835

merged 3 commits into from
Nov 10, 2020

Conversation

owestend
Copy link
Contributor

@owestend owestend commented Nov 2, 2020 •
edited
Loading

XD68 support also a split backspace.

Description

What I did:

  • add macro LAYOUT_65_ansi_split_bs to xd68.h
  • add this layout also to info.json
  • add this layout also to LAYOUTS in rules.mk

What I not did:

  • I did not add the additional key to LAYOUT_all
  • I did not change any other layout

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 2, 2020 13:30
fauxpark
fauxpark requested changes Nov 2, 2020
View reviewed changes
keyboards/xd68/info.json Outdated Show resolved Hide resolved
@owestend @fauxpark
Apply suggestions from code review
3921631 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna requested review from noroadsleft and a team November 3, 2020 00:49
@owestend
Copy link
Contributor Author

owestend commented Nov 9, 2020

What else can I do to get these changes accepted?

@noroadsleft
Copy link
Member

What else can I do to get these changes accepted?

In my case, I was busy with non-QMK stuff and I fell behind on my PR reviews. Sorry for that.

But looks good, thanks!

@noroadsleft noroadsleft merged commit aa90cf1 into qmk:master Nov 10, 2020
@owestend
Copy link
Contributor Author

Thanks!

ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Nov 10, 2020
@owestend @ChrissiQ
XD68: add 65_ansi_split_bs layout (qmk#10835)
ca862da 
* XD68: add 65_ansi_split_bs layuout

* change number of keys in info.json

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owestend @noroadsleft @fauxpark