Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efreet refactor #10806

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Efreet refactor #10806

merged 1 commit into from
Oct 31, 2020

Conversation

fauxpark
Copy link
Member

Description

⚠ efreet: Falling back to searching for KEYMAP/LAYOUT macros.

#10792

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 30, 2020 13:49
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Oct 30, 2020
@zvecr zvecr requested a review from a team October 30, 2020 14:22
@fauxpark
Copy link
Member Author

Travis errors are unrelated - default and via keymaps are good.

@fauxpark fauxpark merged commit d705918 into qmk:master Oct 31, 2020
@fauxpark fauxpark deleted the efreet-refactor branch October 31, 2020 19:56
morrijr pushed a commit to morrijr/qmk_firmware that referenced this pull request Nov 1, 2020
@fauxpark @morrijr
Efreet refactor (qmk#10806)
aa17861
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@fauxpark
Efreet refactor (qmk#10806)
8c914a3
ringmaster pushed a commit to ringmaster/qmk_firmware that referenced this pull request Nov 5, 2020
@fauxpark
Efreet refactor (qmk#10806)
eee8a24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr