qmk info: Add --ascii flag
#10793
Merged
qmk info: Add --ascii flag
#10793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skullydazed
reviewed
Oct 30, 2020
skullydazed
approved these changes
Oct 30, 2020
Comment on lines
+94
to
+98
| def render_layout(layout_data, render_ascii, key_labels=None): | ||
| """Renders a single layout. | ||
| """ | ||
| textpad = [array('u', ' ' * 200) for x in range(50)] | ||
| style = 'ascii' if render_ascii else 'unicode' |
There was a problem hiding this comment.
A thought- it might be more future-proof to do this so we can have other layout styles in the future. Dots? Letters?
Suggested change
| def render_layout(layout_data, render_ascii, key_labels=None): | |
| """Renders a single layout. | |
| """ | |
| textpad = [array('u', ' ' * 200) for x in range(50)] | |
| style = 'ascii' if render_ascii else 'unicode' | |
| def render_layout(layout_data, style='unicode', key_labels=None): | |
| """Renders a single layout. | |
| Args: | |
| style | |
| The style for the box drawing characters. 'ascii' or 'unicode' | |
| key_labels | |
| A sequence of label strings to write on top of the keys | |
| """ | |
| textpad = [array('u', ' ' * 200) for x in range(50)] | |
| style = 'ascii' if render_ascii else 'unicode' |
There was a problem hiding this comment.
I did experiment with other styles a bit. In the end I found that the current ascii style here, with underscores for the horizontals and pipes for everything else, looked the least awful.
This looks way too messy, for example:
noroadsleft
approved these changes
Nov 2, 2020
|
Thanks! |
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
ringmaster
pushed a commit
to ringmaster/qmk_firmware
that referenced
this pull request
Nov 5, 2020
barrettclark
pushed a commit
to barrettclark/qmk_firmware
that referenced
this pull request
Nov 5, 2020
* upstream/master: (153 commits) [Keymap] add brandonschlack userspace and keymaps (qmk#10411) [Keymap] add ai03/polaris:mekberg (qmk#10508) CLI: Add `qmk clean` (qmk#10785) Adds support for XD84 Pro (qmk#9750) Freyr refactor (qmk#10833) KC60 refactor (qmk#10834) [Keyboard] Fixes for PloopyCo mouse and readmes (qmk#10841) Enable extrakeys, mousekeys for all VIA keymaps. (qmk#10740) Add OLED support for Riblee F411 (qmk#10778) NK65 eeprom compatibility with 128KB and 256KB (qmk#10804) Add support for Noxary Vulcan (qmk#10822) Enable media keys support for Canoe VIA keymap (qmk#10829) Phantom refactor (qmk#10805) `qmk info`: Add `--ascii` flag (qmk#10793) [Keymap] Corrected the dvorak layout for kinesis advantage (qmk#10808) [Keyboard] Fix keyboard matrix scan rate with F072 (qmk#10226) [Keyboard] nullbitsco/nibble Configurator rework (qmk#10814) [Keyboard] VIA Support: Exent 65% (qmk#10797) [Keyboard] Add keebsforall/freebird60 (qmk#10774) add 65_ansi_split_bs to default community layouts (qmk#10770) ...
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Nov 24, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 13, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced #10734 with something more useful.
MinGW Python on MSYS2 has trouble rendering the box drawing characters (because it's a native binary and thus thinks the character set is cp1252). As a hacky workaround, we can use ASCII characters instead.
It's not as pretty, but it's something.
Types of Changes
Issues Fixed or Closed by This PR
Checklist