Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard Southpaw66 #10782

Merged
merged 33 commits into from
Nov 14, 2020
Merged

Add Keyboard Southpaw66 #10782

merged 33 commits into from
Nov 14, 2020

Conversation

gooberpsycho
Copy link
Contributor

@gooberpsycho gooberpsycho commented Oct 27, 2020

/u/rpiguy9907 from reddit custom designed this PCB for their own personal use. I got a spare from them and decided to code up QMK and VIA support for it. They have released the schematics and Gerber files on their github available at :
https://github.com/rpiguy9907/Keyboards/tree/master/Southpaw66. It's basically a Clueboard/660 layout but with the mini-nav cluster and arrow keys on the left side instead of right.

Description

A few weeks ago, I coded firmware for a handwired clueboard named "3dp660". I basically just copied all the code from that, changing what needed to be changed. After a few hiccups, it compiled properly and I've tested it with the via json to ensure that it functions properly.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 27, 2020
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename all of the files to ensure that they're all lowercase?

@drashna drashna requested a review from a team October 29, 2020 07:48
@gooberpsycho
Copy link
Contributor Author

Lowercased all instances of "Southpaw66" to "southpaw66" except in one url pointing to original designer's github repo.

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyboard name can still be Southpaw66, but the folder and file names, and any references to those files, must be lowercase.

keyboards/rpiguy9907/Southpaw66/readme.md Outdated Show resolved Hide resolved
@gooberpsycho
Copy link
Contributor Author

Boy, that was a chore and a half. Using github in browser is not very intuitive or user-friendly. Think I got them all though.

@gooberpsycho
Copy link
Contributor Author

just realized, that may cause compatibility problems with via. I had everything capitalized in there too. Or does it just use the product and vendor ID's?

@fauxpark
Copy link
Member

Yes, VIA doesn't care about the filenames as they won't be present in the firmware itself.

@fauxpark fauxpark requested review from a team and drashna November 2, 2020 13:50
gooberpsycho and others added 2 commits November 12, 2020 03:58
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft merged commit d7c1b89 into qmk:master Nov 14, 2020
@noroadsleft
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants