Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Added Crazy Keyboard 68 #10693

Merged
merged 16 commits into from
Nov 10, 2020
Merged

[Keyboard] Added Crazy Keyboard 68 #10693

merged 16 commits into from
Nov 10, 2020

Conversation

z-ww447
Copy link
Contributor

@z-ww447 z-ww447 commented Oct 19, 2020

Description

Added files for Crazy Keyboard 68 from taobao. Everything tested working except for caps lock led (see keyboard.c).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 23, 2020 03:41
keyboards/crazy_keyboard_68/crazy_keyboard_68.c Outdated Show resolved Hide resolved
keyboards/crazy_keyboard_68/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/crazy_keyboard_68/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/crazy_keyboard_68/info.json Outdated Show resolved Hide resolved
keyboards/crazy_keyboard_68/crazy_keyboard_68.h Outdated Show resolved Hide resolved
keyboards/crazy_keyboard_68/rules.mk Show resolved Hide resolved
keyboards/crazy_keyboard_68/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team October 25, 2020 00:12
z-ww447 and others added 7 commits October 26, 2020 14:03
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
@z-ww447 z-ww447 requested review from zvecr and removed request for a team October 27, 2020 07:02
@drashna drashna requested a review from a team October 29, 2020 08:17
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this, please.

keyboards/crazy_keyboard_68/config.h Outdated Show resolved Hide resolved
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@z-ww447 z-ww447 requested a review from noroadsleft November 8, 2020 16:46
@noroadsleft noroadsleft merged commit 8af767c into qmk:master Nov 10, 2020
@noroadsleft
Copy link
Member

Thanks!

ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Nov 10, 2020
* Entry and readme for crazy keyboard 68

* Defined layout in keyboard.h

* Basic setup done

* Working config, keymaps, rgb confirmed. Caps lock led untested

* Update readme.md

Image links

* Update config.h

* Update crazy_keyboard_68.c

#include "quantum.h"

* Match PR

* Update keyboards/crazy_keyboard_68/crazy_keyboard_68.c

* Update keyboards/crazy_keyboard_68/keymaps/default/keymap.c

* Update keyboards/crazy_keyboard_68/keymaps/default/keymap.c

* Update keyboards/crazy_keyboard_68/info.json

* Update keyboards/crazy_keyboard_68/crazy_keyboard_68.h

* Update keyboards/crazy_keyboard_68/rules.mk

* Update keyboards/crazy_keyboard_68/rules.mk

* Update keyboards/crazy_keyboard_68/config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants