Keyboard update: SL40 #10445
Merged
Keyboard update: SL40 #10445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding additional layouts for new PCB version, and correecting incorrect image in info file
zvecr
approved these changes
Sep 26, 2020
fauxpark
approved these changes
Sep 27, 2020
|
Thanks! |
tomohisa
pushed a commit
to tomohisa/qmk_firmware
that referenced
this pull request
Sep 28, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (3643 commits) Swapparoo of bottom row keys (qmk#10277) [Keyboard] Add PloopyCo devices (qmk#7935) Keyboard update: SL40 (qmk#10445) [keyboard] Add SP-111 support (qmk#10193) Add logic for AT90USBxx7 where needed (qmk#10203) Trifecta Keymap [Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces (qmk#10391) `setrgb()`: Use arrow operator (qmk#10451) [Keyboard] add Percent Canoe Gen2 (qmk#10344) [Keyboard] add hannah65 by Team Mechlovin (qmk#10284) Fix Belgian sendstring properly (qmk#10444) Add VIA support for lazydesigners/the30 (qmk#10374) [Keyboard] add duckboard by doodboard (qmk#10318) Fix Belgian sendstring file (qmk#10443) [Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394) CLI/Doctor: Print QMK_HOME (qmk#10398) Add Wyvern Keyboard (qmk#10378) Adding Bear 65 Ergo Keyboard To QMK (qmk#10384) VIA Support: Gray Studio HB85 (qmk#10329) format code according to conventions [skip ci] ...
rgoulter
pushed a commit
to rgoulter/qmk_firmware
that referenced
this pull request
Oct 4, 2020
* adding alpha variants * adding cajal layouts * adding V2 PCB support adding additional layouts for new PCB version, and correecting incorrect image in info file * Cleanup master -- remove alpha9 * Cleanup master -- remove g4m3ralpha * Cleanup master -- remove cajal & sl40 * Master cleanup -- re-add sl40 * Master cleanup -- correct SL40 image * Keyboard addenda: Production version of sl40 Co-authored-by: worldspawn00 <mcmancuso@gmail.com>
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
* adding alpha variants * adding cajal layouts * adding V2 PCB support adding additional layouts for new PCB version, and correecting incorrect image in info file * Cleanup master -- remove alpha9 * Cleanup master -- remove g4m3ralpha * Cleanup master -- remove cajal & sl40 * Master cleanup -- re-add sl40 * Master cleanup -- correct SL40 image * Keyboard addenda: Production version of sl40 Co-authored-by: worldspawn00 <mcmancuso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an update to the wsk/sl40. The original sl40 was a one-off with 48 keys. The updated production PCB has 51 keys. I attempted to craft this in a way to minimize breakage (first by having v1/ and v2/ folders) but settled on renaming the original
defaultkeymap folder toprototype, keeping the originalLAYOUTmacro there, and the new "v2" keymap is now indefaultand utilizesLAYOUT_all. Hopefully this is an acceptable workaround, if still a breaking change.Submitted on behalf of Worldspawn.
Types of Changes
Issues Fixed or Closed by This PR
Checklist