Add support for "The Ave." keyboard #10042

The-Royal · 2020-08-15T00:07:46Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The-Royal · 2020-08-15T00:11:05Z

-___-

zvecr

As its 2 physically different PCBs, it should be split into 2 sub revisions keyboards/kingly_keys/ave/staggered and keyboards/kingly_keys/ave/ortho.

The-Royal · 2020-08-16T02:17:16Z

As its 2 physically different PCBs, it should be split into 2 sub revisions keyboards/kingly_keys/ave/staggered and keyboards/kingly_keys/ave/ortho.

That was the original plan. I wasn't sure on exactly if that was the right idea cause they are two different PCBs...but they use the exact same pin-outs, config and mapping. It could have been a single PCB but I don't like swiss cheese PCBs lol.

The-Royal · 2020-08-16T02:19:12Z

@zvecr How do I structure the split? Two different keyboard folders or staggered subfolder (keymap, json, info, and config) within the main?

The-Royal · 2020-08-16T04:06:41Z

Future revisions/sales of the pcb might actually be just combined (staggered and ortho) onto the single pcb

LostQuasar · 2020-08-16T17:54:47Z

@zvecr How do I structure the split? Two different keyboard folders or staggered subfolder (keymap, json, info, and config) within the main?

look into pancake pro micro and pancake BLE those might help you understand to make different versions

The-Royal · 2020-08-17T04:00:41Z

@zvecr Do I still need the initial ave.c and ave.h files if the sub-folders contain the more consolidated configurations?

LostQuasar · 2020-08-17T14:01:28Z

Since the two variations are widely different I would treat them as 2 separate keyboards and leave the root folder empty

The-Royal · 2020-08-18T13:54:28Z

Alright. Removed the the two unnecessary files. :)

keyboards/kingly_keys/ave/rules.mk

keyboards/kingly_keys/ave/staggered/rules.mk

keyboards/kingly_keys/ave/staggered/keymaps/default/keymap.c

keyboards/kingly_keys/ave/ortho/rules.mk

keyboards/kingly_keys/ave/ortho/keymaps/default/keymap.c

Co-authored-by: Joel Challis <git@zvecr.com>

into royal_ave_pr

noroadsleft

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/kingly_keys/ave/config.h

keyboards/kingly_keys/ave/ortho/info.json

keyboards/kingly_keys/ave/readme.md

keyboards/kingly_keys/ave/staggered/info.json

keyboards/kingly_keys/ave/readme.md

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

The-Royal · 2020-10-14T17:13:28Z

Yeah I think every PR I have open has had some issue with the Tapping term specifically.

It was working perfectly before the PR with the same Rev split into two keymaps of Ortho/staggered.

Travis doesn’t seem to have an issue with the build strangely enough.

ridingqwerty · 2020-10-14T17:22:30Z

Travis doesn’t seem to have an issue with the build strangely enough.

Yeah I did notice that. I would try building yourself anyway, but maybe it's just me. I could definitely make kingly_keys/romac:default and other stuff no problem.

noroadsleft · 2020-10-16T18:02:43Z

I feel like this isn't correct...

fauxpark · 2020-10-17T01:10:40Z

Yep, rules.mk is missing from the staggered and ortho directories.

The-Royal · 2020-10-27T23:08:29Z

Yep, rules.mk is missing from the staggered and ortho directories.

Do I need one in the parent board directories too?

Or should i just duplicate and move the rules.mk from the master parent to the sub directories?

There is one for each default Keymap currently

noroadsleft · 2020-10-28T00:57:00Z

Do I need one in the parent board directories too?

Or should i just duplicate and move the rules.mk from the master parent to the sub directories?

Yeah, Take keyboards/kingly_keys/ave/rules.mk and move it to the ortho directory, and then copy it to the staggered directory. So:

cd keyboards/kingly_keys/ave/
git mv -- rules.mk ortho/rules.mk
cp ortho/rules.mk staggered/rules.mk
git add -- staggered/rules.mk
git commit -m "move keyboard rules.mk to version level"

keyboards/kingly_keys/ave/config.h

keyboards/kingly_keys/ave/readme.md

Co-authored-by: Ryan <fauxpark@gmail.com>

keyboards/kingly_keys/ave/config.h

Co-authored-by: Ryan <fauxpark@gmail.com>

noroadsleft

Looks good to me.

noroadsleft · 2020-11-10T05:03:18Z

Thanks!

* Add configurator support for "The Ave." keyboard * Update readme.md * update misc nomenclature * add punctuation * fix miss-placed "0" * update README.md * del. duplicate "F11" in visual layout information * Split PCB configurations into subfolders * update layer template to new matrix title * rm primary <keyboard>.c / <keyboard>.h files * add new end line to both .h subfolder fiels * Apply suggestions from code review * tested update to RGB code * update rgb code * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update rules.mk * Update rules.mk * Delete rules.mk * Delete rules.mk * Update rules.mk * Update config.h * Update config.h * Update keymap.c * Update ortho.c * Update ortho.h * Update config.h * Update keymap.c * Update staggered.c * Update staggered.h * Apply suggestions from code review * Update config.h * Update keymap.c * move and duplicate rules.mk file * Update keyboards/kingly_keys/ave/readme.md * Update config.h * Update keyboards/kingly_keys/ave/config.h

mtei · 2020-11-14T09:46:19Z

This PR#10042 has a build error, but it has been merged. Why?

fauxpark · 2020-11-14T10:01:03Z

The build failure is not really anything to do with this keyboard's code itself - it's complaining that TAPPING_TERM is not defined, which is technically true as far as the keymap.c is concerned. TAPPING_TERM, if not defined in config.h, is defaulted to 200 in action_tapping.h, however this header is only included in a handful of .c files so it will not be visible to keymap.c.

It should be moved somewhere both action_tapping.c and quantum.h can see it. Maybe action.h?

mtei · 2020-11-14T20:23:13Z

workaround:

diff --git a/keyboards/kingly_keys/ave/post_config.h b/keyboards/kingly_keys/ave/post_config.h
new file mode 100644
index 000000000..9a69b420f
--- /dev/null
+++ b/keyboards/kingly_keys/ave/post_config.h
@@ -0,0 +1,4 @@
+#ifndef TAPPING_TERM
+#    define TAPPING_TERM 200
+#endif
+

drashna · 2020-12-05T20:28:26Z

This PR#10042 has a build error, but it has been merged. Why?

I have a fix coming for this. That should help detect when tapping term is incorrectly set, either the tapping term itself or the functions.

Which is mostly... just adding action_tapping.h to quantum.h, and adding the function prototypes to action_tapping.h. This should fix this issue, and better handle things everywhere.

Garret G added 4 commits August 14, 2020 18:59

Add configurator support for "The Ave." keyboard

0dfa294

Update readme.md

7fde558

update misc nomenclature

171a17a

add punctuation

bc37794

Garret G added 3 commits August 14, 2020 19:12

fix miss-placed "0"

c00114f

update README.md

b707107

del. duplicate "F11" in visual layout information

4046187

zvecr requested changes Aug 16, 2020

View reviewed changes

zvecr added the keyboard label Aug 16, 2020

Split PCB configurations into subfolders

8eebcf3

update layer template to new matrix title

04600b2

Garret G added 2 commits August 18, 2020 08:43

rm primary <keyboard>.c / <keyboard>.h files

71f0e33

add new end line to both .h subfolder fiels

7a66957

zvecr requested changes Aug 18, 2020

View reviewed changes

zvecr requested a review from a team August 18, 2020 23:06

The-Royal and others added 4 commits August 19, 2020 10:22

Apply suggestions from code review

8a498fe

Co-authored-by: Joel Challis <git@zvecr.com>

tested update to RGB code

f9838c0

Merge branch 'royal_ave_pr' of https://github.com/The-Royal/qmk_firmware

7202711

into royal_ave_pr

update rgb code

6cbac75

noroadsleft requested changes Aug 19, 2020

View reviewed changes

The-Royal and others added 2 commits August 19, 2020 16:56

Apply suggestions from code review

75f417c

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

Apply suggestions from code review

73444ef

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

move and duplicate rules.mk file

fd87633

fauxpark reviewed Oct 28, 2020

View reviewed changes

keyboards/kingly_keys/ave/config.h Outdated Show resolved Hide resolved

fauxpark requested changes Oct 28, 2020

View reviewed changes

keyboards/kingly_keys/ave/readme.md Outdated Show resolved Hide resolved

The-Royal and others added 2 commits October 28, 2020 06:52

Update keyboards/kingly_keys/ave/readme.md

1282645

Co-authored-by: Ryan <fauxpark@gmail.com>

Update config.h

999d412

fauxpark requested changes Oct 28, 2020

View reviewed changes

keyboards/kingly_keys/ave/config.h Outdated Show resolved Hide resolved

Update keyboards/kingly_keys/ave/config.h

5eaf700

Co-authored-by: Ryan <fauxpark@gmail.com>

noroadsleft approved these changes Nov 8, 2020

View reviewed changes

fauxpark approved these changes Nov 8, 2020

View reviewed changes

noroadsleft merged commit 53f1166 into qmk:master Nov 10, 2020

fauxpark mentioned this pull request Dec 5, 2020

[Keyboard] Fix compiler errors for Kingly Key boards #11100

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for "The Ave." keyboard #10042

Add support for "The Ave." keyboard #10042

The-Royal commented Aug 15, 2020 •

edited

Loading

The-Royal commented Aug 15, 2020

zvecr left a comment

The-Royal commented Aug 16, 2020

The-Royal commented Aug 16, 2020

The-Royal commented Aug 16, 2020

LostQuasar commented Aug 16, 2020

The-Royal commented Aug 17, 2020

LostQuasar commented Aug 17, 2020

The-Royal commented Aug 18, 2020

noroadsleft left a comment

The-Royal commented Oct 14, 2020

ridingqwerty commented Oct 14, 2020

noroadsleft commented Oct 16, 2020

fauxpark commented Oct 17, 2020

The-Royal commented Oct 27, 2020

noroadsleft commented Oct 28, 2020

noroadsleft left a comment

noroadsleft commented Nov 10, 2020

mtei commented Nov 14, 2020

fauxpark commented Nov 14, 2020 •

edited

Loading

mtei commented Nov 14, 2020

drashna commented Dec 5, 2020 •

edited

Loading

Add support for "The Ave." keyboard #10042

Add support for "The Ave." keyboard #10042

Conversation

The-Royal commented Aug 15, 2020 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

The-Royal commented Aug 15, 2020

zvecr left a comment

Choose a reason for hiding this comment

The-Royal commented Aug 16, 2020

The-Royal commented Aug 16, 2020

The-Royal commented Aug 16, 2020

LostQuasar commented Aug 16, 2020

The-Royal commented Aug 17, 2020

LostQuasar commented Aug 17, 2020

The-Royal commented Aug 18, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

The-Royal commented Oct 14, 2020

ridingqwerty commented Oct 14, 2020

noroadsleft commented Oct 16, 2020

fauxpark commented Oct 17, 2020

The-Royal commented Oct 27, 2020

noroadsleft commented Oct 28, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

noroadsleft commented Nov 10, 2020

mtei commented Nov 14, 2020

fauxpark commented Nov 14, 2020 • edited Loading

mtei commented Nov 14, 2020

drashna commented Dec 5, 2020 • edited Loading

The-Royal commented Aug 15, 2020 •

edited

Loading

fauxpark commented Nov 14, 2020 •

edited

Loading

drashna commented Dec 5, 2020 •

edited

Loading