Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handwired pteron38 #10035

Merged
merged 8 commits into from
Aug 26, 2020
Merged

Handwired pteron38 #10035

merged 8 commits into from
Aug 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2020

Adding new keyboard layout. Pteron already exists, but this is a 38 key variant. I chose to create a new keyboard folder rather than add a new layout to Pteron folder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove firmware filesize changes from rules.mk option and change imgur link in readme to a direct link.

alzafacon and others added 2 commits August 19, 2020 06:39
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a GPL2+ compatible license header to all of the c and h files in this PR?

@drashna drashna requested a review from a team August 23, 2020 23:39
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

alzafacon and others added 2 commits August 25, 2020 06:51
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft requested a review from a team August 25, 2020 19:08
@noroadsleft noroadsleft merged commit bad662b into qmk:master Aug 26, 2020
@noroadsleft
Copy link
Member

Thanks!

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* setup handwired pteron38

* Clean up readme

* readme follow template

* c formatting conventions

* remove  file size comments from rules.mk

* use direct link to imgur image

* Apply suggestions from code review

* add license
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* setup handwired pteron38

* Clean up readme

* readme follow template

* c formatting conventions

* remove  file size comments from rules.mk

* use direct link to imgur image

* Apply suggestions from code review

* add license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants