Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Italian translation #557

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Added Italian translation #557

merged 3 commits into from
Oct 31, 2019

Conversation

michizhou
Copy link
Contributor

I just created the Italian (it) translation folder and added all the necessary translations. Suggestions for any potential improvements to the documentation are welcome.

@qmk qmk deleted a comment from gargarchit Oct 26, 2019
@yanfali
Copy link
Collaborator

yanfali commented Oct 26, 2019

@michizhou are you a native Italian speaker or is this Google translate?

@yanfali yanfali added on hold Pull requests that are waiting on other changes to be merged. translation labels Oct 26, 2019
@michizhou
Copy link
Contributor Author

michizhou commented Oct 27, 2019

@yanfali I studied Italian for two years in college (just a few years ago). This isn't Google Translate.

@yanfali
Copy link
Collaborator

yanfali commented Oct 28, 2019

Here's some feedback from someone I know who lived in Italy for about a decade:

Screen Shot 2019-10-28 at 12 30 35

Copy link
Contributor

@sahalsaad sahalsaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change to avoid conflict with English translation.

src/i18n/it/index.js Outdated Show resolved Hide resolved
@noroadsleft noroadsleft added awaiting changes Waiting for the submitter to post an update. and removed on hold Pull requests that are waiting on other changes to be merged. labels Oct 30, 2019
@noroadsleft noroadsleft removed the awaiting changes Waiting for the submitter to post an update. label Oct 31, 2019
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@noroadsleft noroadsleft merged commit 7b83495 into qmk:master Oct 31, 2019
@federikovi
Copy link
Contributor

Ciao! 👋
I am an Italian native speaker and I wanted to translate the documentation, I've seen there's already work done in this PR but I can't find the it folder in the docs. Has it been deleted?

@yanfali
Copy link
Collaborator

yanfali commented Feb 24, 2022

Hi, the way we do translations changed. We now use csv files, there should be a readme. https://github.com/qmk/qmk_configurator/blob/master/internationalization_guide.md

@federikovi
Copy link
Contributor

@yanfali Great, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants