-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Russian translation 2 (partial) #528
Conversation
@StrikerRUS you guys seem to work well together. Any input? |
@yanfali Sure! I'll drop my review in a while. Thanks for the ping! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few real mistakes, and the most comments is about better wording / taste preferences.
Thanks @StrikerRUS ❤️ |
2e0498e
to
dbb6343
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except that comment #528 (comment)! Great work @nabokovas !
cc @yanfali
@nabokovas build is still failing. @StrikerRUS maybe you can help them out. |
@yanfali I'm so sorry, but I'm not familiar with JS stuff at all. Since the linter seems to be not so verbose (it's just saying that there is a problem in
|
@StrikerRUS I've checked it and running |
@nabokovas I can't merge this until you fix the formatting. Do you need help? |
@yanfali I’m really sorry but I don’t have the environment for full testing, so I made a comparison of the files in English and Russian and also checked with https://prettier.io/. This cite just changes the types of quotes (' for ” and vice versa). I’m trying to find the mistake now. Do you have a string length limit? |
@nabokovas I'll send you a pull request |
WIP for better Any translation |
@nabokovas are you ready to merge? |
I think yes If @StrikerRUS has no more comments about the accuracy of the translation. @StrikerRUS, do you have any? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have any?
No, I don't.
LGTM!
Thanks folks @StrikerRUS and @nabokovas |
Here is the second part of the translation (finished). The translation requires review. I have doubts about some words (such as Flash) because they have no direct analogs in Russian.