Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Russian translation 2 (partial) #528

Merged
merged 8 commits into from
Oct 14, 2019

Conversation

nabokovas
Copy link
Contributor

@nabokovas nabokovas commented Oct 7, 2019

Here is the second part of the translation (finished). The translation requires review. I have doubts about some words (such as Flash) because they have no direct analogs in Russian.

@yanfali
Copy link
Collaborator

yanfali commented Oct 7, 2019

@StrikerRUS you guys seem to work well together. Any input?

@StrikerRUS
Copy link
Contributor

@yanfali Sure! I'll drop my review in a while. Thanks for the ping!

@yanfali
Copy link
Collaborator

yanfali commented Oct 8, 2019

@nabokovas

Checking formatting...
src/i18n/ru/index.js
Code style issues found in the above file(s). Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn run prettier:check" exited with 1.```

Copy link
Contributor

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few real mistakes, and the most comments is about better wording / taste preferences.

src/i18n/ru/index.js Outdated Show resolved Hide resolved
src/i18n/ru/index.js Outdated Show resolved Hide resolved
src/i18n/ru/index.js Outdated Show resolved Hide resolved
src/i18n/ru/index.js Outdated Show resolved Hide resolved
src/i18n/ru/index.js Outdated Show resolved Hide resolved
src/i18n/ru/index.js Outdated Show resolved Hide resolved
src/i18n/ru/index.js Outdated Show resolved Hide resolved
src/i18n/ru/tester.js Outdated Show resolved Hide resolved
src/i18n/ru/tester.js Outdated Show resolved Hide resolved
src/i18n/ru/tester.js Outdated Show resolved Hide resolved
@yanfali
Copy link
Collaborator

yanfali commented Oct 8, 2019

Thanks @StrikerRUS ❤️

@nabokovas nabokovas force-pushed the add_russian_partial_2 branch from 2e0498e to dbb6343 Compare October 9, 2019 22:08
Copy link
Contributor

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that comment #528 (comment)! Great work @nabokovas !

cc @yanfali

@yanfali
Copy link
Collaborator

yanfali commented Oct 10, 2019

@nabokovas build is still failing. @StrikerRUS maybe you can help them out.

@StrikerRUS
Copy link
Contributor

@yanfali I'm so sorry, but I'm not familiar with JS stuff at all. Since the linter seems to be not so verbose (it's just saying that there is a problem in index.js), I have no idea what's wrong.

Checking formatting...
src/i18n/ru/index.js
Code style issues found in the above file(s). Forgot to run Prettier?

@wojciechgabrys
Copy link
Contributor

wojciechgabrys commented Oct 10, 2019

@StrikerRUS I've checked it and running yarn run prettier:fix will fix it automatically (I can't help you with it here, because I can't review PRs in this repo).

@yanfali
Copy link
Collaborator

yanfali commented Oct 10, 2019

@nabokovas I can't merge this until you fix the formatting. Do you need help?

@nabokovas
Copy link
Contributor Author

@yanfali I’m really sorry but I don’t have the environment for full testing, so I made a comparison of the files in English and Russian and also checked with https://prettier.io/. This cite just changes the types of quotes (' for ” and vice versa). I’m trying to find the mistake now. Do you have a string length limit?

@yanfali
Copy link
Collaborator

yanfali commented Oct 10, 2019

@nabokovas I'll send you a pull request

@yanfali
Copy link
Collaborator

yanfali commented Oct 11, 2019

@nabokovas nabokovas#1

@nabokovas
Copy link
Contributor Author

WIP for better Any translation

@nabokovas nabokovas changed the title added Russian translation 2 (partial) [WIP] added Russian translation 2 (partial) Oct 11, 2019
@yanfali
Copy link
Collaborator

yanfali commented Oct 11, 2019

@nabokovas are you ready to merge?

@nabokovas
Copy link
Contributor Author

I think yes If @StrikerRUS has no more comments about the accuracy of the translation. @StrikerRUS, do you have any?

@nabokovas nabokovas changed the title [WIP] added Russian translation 2 (partial) added Russian translation 2 (partial) Oct 13, 2019
Copy link
Contributor

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any?

No, I don't.

LGTM!

@yanfali
Copy link
Collaborator

yanfali commented Oct 14, 2019

Thanks folks @StrikerRUS and @nabokovas

@yanfali yanfali merged commit 7a469fd into qmk:master Oct 14, 2019
@qmk qmk deleted a comment from raghavdhingra Oct 23, 2019
@qmk qmk deleted a comment from sanxy Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants