Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Russian translation (partial) #519

Merged
merged 5 commits into from
Oct 6, 2019
Merged

added Russian translation (partial) #519

merged 5 commits into from
Oct 6, 2019

Conversation

StrikerRUS
Copy link
Contributor

Translated potato.js and print.js.

Copy link
Contributor

@nabokovas nabokovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, StrikerRus! I left a few comments about the translation. As for the rest of the translation, I have no problems.

src/i18n/ru/potato.js Outdated Show resolved Hide resolved
src/i18n/ru/potato.js Outdated Show resolved Hide resolved
src/i18n/ru/potato.js Outdated Show resolved Hide resolved
src/i18n/ru/potato.js Outdated Show resolved Hide resolved
@StrikerRUS
Copy link
Contributor Author

@nabokovas Thanks a lot for your detailed review! Just addressed it in the latest commit.

@StrikerRUS
Copy link
Contributor Author

@noroadsleft Can you please consider adding hacktoberfest label to this PR as well?

src/i18n/ru/index.js Outdated Show resolved Hide resolved
@yanfali yanfali added the WIP Work in Progress label Oct 6, 2019
@yanfali
Copy link
Collaborator

yanfali commented Oct 6, 2019

we're removing hackoctoberfest labels because this will be done at the end of the event rather then per PR to prevent brigading and people trying to get points from just commenting

@StrikerRUS
Copy link
Contributor Author

@yanfali Make sense! Is this PR ready to be merged?

@yanfali
Copy link
Collaborator

yanfali commented Oct 6, 2019

@StrikerRUS is this done? I need to test it first

@StrikerRUS
Copy link
Contributor Author

@yanfali Yep, this PR is ready from my side.

@yanfali
Copy link
Collaborator

yanfali commented Oct 6, 2019

@StrikerRUS can you rebase onto current master please? You'll also need to do step 5 of this guide https://github.com/qmk/qmk_configurator/tree/master/src/i18n to add Russian to the list of languages that can be forced on.

@StrikerRUS
Copy link
Contributor Author

StrikerRUS commented Oct 6, 2019

@yanfali Seems that step is a new one, because I can't remember I saw it when created my PR. I've just rebased and done that step. Please check.

@yanfali
Copy link
Collaborator

yanfali commented Oct 6, 2019

@StrikerRUS yes, it's brand new. We changed it to make it easier to override language pref if you are a French man for example who actually likes English. @zekth

Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Looks Good To Me)

@yanfali yanfali merged commit 7da46c8 into qmk:master Oct 6, 2019
@yanfali
Copy link
Collaborator

yanfali commented Oct 6, 2019

@StrikerRUS @nabokovas thank you both for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants