-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Russian translation (partial) #519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, StrikerRus! I left a few comments about the translation. As for the rest of the translation, I have no problems.
@nabokovas Thanks a lot for your detailed review! Just addressed it in the latest commit. |
@noroadsleft Can you please consider adding |
we're removing hackoctoberfest labels because this will be done at the end of the event rather then per PR to prevent brigading and people trying to get points from just commenting |
@yanfali Make sense! Is this PR ready to be merged? |
@StrikerRUS is this done? I need to test it first |
@yanfali Yep, this PR is ready from my side. |
@StrikerRUS can you rebase onto current master please? You'll also need to do step 5 of this guide https://github.com/qmk/qmk_configurator/tree/master/src/i18n to add Russian to the list of languages that can be forced on. |
@yanfali Seems that step is a new one, because I can't remember I saw it when created my PR. I've just rebased and done that step. Please check. |
@StrikerRUS yes, it's brand new. We changed it to make it easier to override language pref if you are a French man for example who actually likes English. @zekth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Looks Good To Me)
@StrikerRUS @nabokovas thank you both for your contribution |
Translated
potato.js
andprint.js
.