Add Spanish translation #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update index.js with prettier
|
As stated in #513, the translation instructions should mention running Prettier to appease Travis CI. |
|
@kbravh yeah, I think this is something I don't really pay attention to because I'm usually running yarn serve and it yells at me immediately when something is mal formatted. That's why we have travis 😄 |
yanfali
reviewed
Oct 4, 2019
yanfali
reviewed
Oct 4, 2019
yanfali
requested changes
Oct 4, 2019
yanfali
reviewed
Oct 4, 2019
yanfali
approved these changes
Oct 4, 2019
namelivia
suggested changes
Oct 4, 2019
|
@namelivia I have updated the typos you found, and I also switched plano out for layout. Thanks for the review! |
|
@namelivia you can approve the PR if you agree. Then I'll merge. Thank you both so much |
namelivia
suggested changes
Oct 4, 2019
|
OK, let me know guys when you want to merge. |
namelivia
approved these changes
Oct 4, 2019
|
Thank you so much folks. This is much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created the Spanish (es) translation folder and added all the necessary translations. I also added Spanish as an option in the Language dropdown in SettingsPanel.vue on line 83. This was not part of the translation readme (should it be? 🤷♂️).