Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting fix. #145

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Formatting fix. #145

merged 6 commits into from
Apr 5, 2023

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 2, 2023

Description

Seems including a % in the console output throws errors.

See qmk/qmk_firmware#20238

Seems like a potential bug in milc but we don't have access to that.

Tested using:

python3 -m pip uninstall -y qmk
python3 -m pip install git+https://github.com/qmk/qmk_cli.git@attempted-formatting-fix

@tzarc tzarc requested a review from a team April 2, 2023 00:28
@tzarc tzarc changed the title Attempted formatting fix. Formatting fix. Apr 2, 2023
@tzarc tzarc mentioned this pull request Apr 2, 2023
14 tasks
@tzarc tzarc marked this pull request as ready for review April 2, 2023 00:37
tzarc and others added 3 commits April 3, 2023 07:43
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@tzarc tzarc merged commit 5019970 into master Apr 5, 2023
@tzarc tzarc deleted the attempted-formatting-fix branch April 5, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants