-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy phpstan config into tool dir #1482
Conversation
Diff Coverage: The code coverage on the diff in this pull request is 55.6%. Total Coverage: This PR will not change total coverage. File Coverage Changes
🛟 Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the code, but would like to get confirmation from the customer this works before merging
Similar to eslint, phpstan config files also load dependencies relative to config file path, so we should copy the phpstan configs into tool directory where we install the packages.