-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default behavior for missing output #1466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 new issue
|
brynary
added a commit
that referenced
this pull request
Feb 5, 2025
marschattha
added a commit
that referenced
this pull request
Feb 5, 2025
#1466 again with `output_missing = "parse"` for all linters except eslint and kubelint --------- Co-authored-by: Bryan Helmkamp <bryan@brynary.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if a linter exited with a success exit code but did not produce any output, we would hand an empty string to the parser. In substantially all situations, this will result in a confusing EOF error from the parser, because it will try to e.g. parse an empty string as JSON.
This PR changes the default -- If a linter exits with a success exit code, but does not produce output, we will treat that as a Lint Error and skip the parser phase entirely.
This behavior can be overridden by two alternative behaviors:
parse
orno_issues
.parse
will invoke the parser with an empty string, andno_issues
will treat the empty output as if it produced output along the lines ofissues = []
(Previously, we had a
missing_output_as_error
boolean. The newoutput_missing
enum replaces that.)