Fix off-by-1 offset in ripgrep column info #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ripgrep uses 0-indexed column values which is not used by other linter output
larkinscott
approved these changes
Jan 14, 2025
brynary
approved these changes
Jan 14, 2025
qlty-check/src/parser/ripgrep.rs
Outdated
| @@ -100,9 +100,9 @@ impl Parser for Ripgrep { | |||
| path: path.text.clone(), | |||
| range: Some(Range { | |||
| start_line: line_number, | |||
| start_column: submatch.start, | |||
| start_column: submatch.start + 1, | |||
There was a problem hiding this comment.
Not sure if there's a docs page which references this behavior but if not could you please add a comment just clarifying the discovery and the need for this +1?
There was a problem hiding this comment.
Haven't really found any explicit documentation for this, it was discovered while dogfooding our tools.
qlty-check/src/parser/ripgrep.rs
Outdated
| @@ -100,9 +100,9 @@ impl Parser for Ripgrep { | |||
| path: path.text.clone(), | |||
| range: Some(Range { | |||
| start_line: line_number, | |||
| start_column: submatch.start, | |||
| start_column: submatch.start + 1, | |||
There was a problem hiding this comment.
Not sure if there's a docs page which references this behavior but if not could you please add a comment just clarifying the discovery and the need for this +1?
|
The plugin tests might also need updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ripgrep uses 0-indexed column values which is not used by other linter output