Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require qlty.toml for coverage command #1194

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Do not require qlty.toml for coverage command #1194

merged 1 commit into from
Nov 20, 2024

Conversation

lsegal
Copy link
Member

@lsegal lsegal commented Nov 20, 2024

Use default config options if qlty.toml is not present.

@lsegal
Do not require qlty.toml for coverage command
57fc3fa 
Use default config options if qlty.toml is not present.
@lsegal lsegal requested a review from brynary November 20, 2024 22:42
@lsegal lsegal added the bug label Nov 20, 2024
@lsegal lsegal self-assigned this Nov 20, 2024
@lsegal lsegal requested review from marschattha and a team and removed request for brynary and marschattha November 20, 2024 22:42
@qltysh qltysh
Copy link
Contributor

qltysh bot commented Nov 20, 2024 •
edited
Loading

The code coverage on the diff in this pull request is 0.0%

Drilldown
Path File Coverage Δ
qlty-check/src/tool/command_builder.rs 2.6
qlty-config/src/library.rs -0.7
qlty-cli/src/initializer/scanner/gemfile.rs -0.3
qlty-check/src/tool/ruby/sys/macos.rs 3.1
qlty-check/src/tool/download.rs 0.7
qlty-check/src/tool/ruby/sys/linux.rs -1.6

marschattha
marschattha approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@marschattha marschattha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lsegal lsegal merged commit f8704dc into main Nov 20, 2024
8 checks passed
@lsegal lsegal deleted the ls/no-require-coverage-config branch November 20, 2024 22:44
This was referenced Jan 15, 2025
Merged
Merged
marschattha added a commit that referenced this pull request Jan 15, 2025
@marschattha
Update coverage tests to run without qlty config (#1429)
29ebce2 
Update tests to cover change in #1194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marschattha marschattha marschattha approved these changes

Assignees

@lsegal lsegal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsegal @marschattha