Count properties as fields

qltysh · Jan 8, 2025 · c7fb1e7 · c7fb1e7
1 parent 0cc3342
commit c7fb1e7
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 14 deletions.
diff --git a/qlty-analysis/src/lang/csharp.rs b/qlty-analysis/src/lang/csharp.rs
@@ -27,11 +27,12 @@ const FUNCTION_DECLARATION_QUERY: &str = r#"
 "#;
 
 const FIELD_QUERY: &str = r#"
-  (field_declaration 
-    (variable_declaration 
-      (variable_declarator name: (identifier) @name)
-    )
-  ) @field
+    [(field_declaration
+        (variable_declaration 
+        (variable_declarator name: (identifier) @name)
+        )
+    ) @field
+    (property_declaration name: (identifier) @name) @field]
 "#;
 
 pub struct CSharp {

diff --git a/...csharp/pending/GetterSetterDeclaration.cs → ...asic.in/fields/GetterSetterDeclaration.cs b/...csharp/pending/GetterSetterDeclaration.cs → ...asic.in/fields/GetterSetterDeclaration.cs
@@ -3,11 +3,13 @@ namespace Fields
     public class GetterSetterDeclaration
     {
         public string Field { get; set; }
+        public string _field2
 
         public static void Main(string[] args)
         {
             GetterSetterDeclaration obj = new GetterSetterDeclaration();
             obj.Field = "Hello";
+            obj._field2 = "World";
             System.Console.WriteLine(obj.Field);
         }
     }

diff --git a/qlty-cli/tests/lang/csharp/basic.stdout b/qlty-cli/tests/lang/csharp/basic.stdout
@@ -2,7 +2,7 @@
   "metadata": {
     "buildId": "[..]",
     "result": "ANALYSIS_RESULT_SUCCESS",
-    "filesAnalyzed": 42,
+    "filesAnalyzed": 43,
     "startTime": "[..]",
     "finishTime": "[..]",
     "commitMessage": "initial/n",
@@ -872,6 +872,26 @@
       "cyclomatic": 2,
       "lcom4": 1
     },
+    {
+      "buildId": "[..]",
+      "analyzedAt": "[..]",
+      "name": "GetterSetterDeclaration.cs",
+      "fullyQualifiedName": "fields/GetterSetterDeclaration.cs",
+      "path": "fields/GetterSetterDeclaration.cs",
+      "kind": "COMPONENT_TYPE_FILE",
+      "language": "LANGUAGE_C_SHARP",
+      "files": 1,
+      "classes": 1,
+      "functions": 1,
+      "fields": 2,
+      "lines": 16,
+      "codeLines": 14,
+      "commentLines": 0,
+      "blankLines": 2,
+      "complexity": 0,
+      "cyclomatic": 1,
+      "lcom4": 0
+    },
     {
       "buildId": "[..]",
       "analyzedAt": "[..]",
@@ -1237,16 +1257,16 @@
       "fullyQualifiedName": "fields",
       "path": "fields",
       "kind": "COMPONENT_TYPE_DIRECTORY",
-      "files": 9,
-      "classes": 10,
-      "functions": 12,
-      "fields": 13,
-      "lines": 138,
-      "codeLines": 112,
+      "files": 10,
+      "classes": 11,
+      "functions": 13,
+      "fields": 15,
+      "lines": 154,
+      "codeLines": 126,
       "commentLines": 4,
-      "blankLines": 22,
+      "blankLines": 24,
       "complexity": 0,
-      "cyclomatic": 10,
+      "cyclomatic": 11,
       "lcom4": 1
     },
     {