fix: correctly handle comma-separated file paths #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update file path processing to properly split and handle comma-separated paths, ensuring each path is treated as a separate entry when passed to the coverage tool.
8418871 to
d5324ef
Compare
marschattha
approved these changes
Jan 16, 2025
|
@marschattha That's a good point and something that was discussed briefly in the ticket. We agreed that a breaking change was ok and expected with this update, but I like your idea of leaning into versioning to roll this (or other breaking changes) out more smoothly. Will have a look at that before merging. |
|
I don't have much context on the background for this, but also, I was thinking, considering this is a breaking change, should we go with a deprecated warning for space separated file names? That way, it won't straight up blow everyone's workflow who is already using it? |
|
@marschattha I pushed up a new commit that temporarily handles both cases and logs a deprecation warning: 509ae8f. Thoughts? |
509ae8f to
d853f4c
Compare
marschattha
approved these changes
Jan 16, 2025
This begins to handle comma-seperated `files` input while still supporting space-seperated `files` input, but logging a warning message about the deprecation.
d853f4c to
08a9207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update file path processing to properly split and handle comma-separated paths, ensuring each path is treated as a separate entry when passed to the coverage tool.