Skip to content
This repository was archived by the owner on Aug 8, 2024. It is now read-only.

fix: table moves up when doing selection #627

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Conversation

LiKang6688
Copy link
Contributor

@LiKang6688 LiKang6688 commented Aug 10, 2022

Head:
when a focused cell is updated, the scroll position is updated accordingly.

abc! (3)

Current:
only when using the keyboard to move up, the scroll position is updated accordingly

table.mov

Limitation:

For a very narrow table, the best we can do is that arrow up scroll behavior is the same as the arrow down scroll behavior
Head:

table.mov

Current:

table1.mov

@LiKang6688 LiKang6688 force-pushed the fix/selecting-scroll branch from bec5cc8 to affa9f8 Compare August 10, 2022 13:57
@LiKang6688 LiKang6688 requested a review from haxxmaxx August 11, 2022 06:26
@haxxmaxx
Copy link
Collaborator

If I understand the limitation, it only happens when your header is bigger than the whole body. Should be a really uncommon use case

@LiKang6688
Copy link
Contributor Author

If I understand the limitation, it only happens when your header is bigger than the whole body. Should be a really uncommon use case

Right, an uncommon one, and it is good that we know it in advance.

@LiKang6688 LiKang6688 requested a review from haxxmaxx August 11, 2022 07:51
@haxxmaxx
Copy link
Collaborator

Really nice that we could solve this without introducing forwardRef, great work

@LiKang6688 LiKang6688 merged commit 1b4f749 into main Aug 11, 2022
@LiKang6688 LiKang6688 deleted the fix/selecting-scroll branch August 11, 2022 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants