This repository was archived by the owner on Aug 8, 2024. It is now read-only.
refactor: type events to remove need to cast #1126
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentTarget
which can actually be typed. This removes most castings toHTMLElement
There are a couple exceptions:onContextMenu,
since we don't control where the event comes fromgetElementsByClassName,
since the return type is not genericisEventFromColumnAdjuster
, since we might move this to common repoFocusEvent
, the target types are hard codedcurrentElement
in the keyboard functions, and we already get fromclosest
inonContextMenu
. plus the arg type becomes simpler