This repository was archived by the owner on Aug 8, 2024. It is now read-only.
perf: stale page check #1019
Closed
perf: stale page check #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbt1
commented
Jun 1, 2023
cbt1
commented
Jun 3, 2023
| qLeft <= colEndIndex && | ||
| qTop >= rowStartIndex && | ||
| qTop <= rowEndIndex && | ||
| qLeft + qWidth >= colStartIndex && |
There was a problem hiding this comment.
Note to self: Should be an OR not an AND operator between the points
|
Looking through my review requests and found this. Should I take a look? |
I think you can wait. It will take a look at the "note to self" when I get the time. It should still be valid. |
|
Closing, lets do something similar to PVT where fetching is throttled/debounced and uses two buffers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user scrolls, a scroll event listener starts a process to check if cells that are scrolled into view are missing data. When this is the case a request to fetch data for those missing cells is sent to Engine. But sometimes the user scrolls rather quickly, so quickly that some of the cells that where empty and needed data, are no longer in the visible view of the user.
This PR attempts to optimize that process, so that when a cell is no longer visible to the user and the data has not already been fetch. It's considered stale and not included in the next data fetch.