refactor: handleNavigateTop

qlik-oss · Jun 14, 2022 · f012fb7 · f012fb7
1 parent 38abf12
commit f012fb7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/table/components/TableWrapper.jsx b/src/table/components/TableWrapper.jsx
@@ -92,9 +92,8 @@ export default function TableWrapper(props) {
     const memoedContainer = tableBodyWrapperRef.current;
     if (!memoedContainer) return () => {};
 
-    const keyDownHandler = (evt) => {
+    const keyDownHandler = (evt) =>
       evt.key === 'ArrowUp' && handleNavigateTop({ tableContainerRef, focusedCellCoord, rootElement });
-    };
     memoedContainer.addEventListener('keydown', keyDownHandler);
 
     return () => {

diff --git a/src/table/utils/handle-scroll.js b/src/table/utils/handle-scroll.js
@@ -26,7 +26,7 @@ export const handleHorizontalScroll = (evt, isRTL, memoedContainer) => {
 };
 
 export const handleNavigateTop = ({ tableContainerRef, focusedCellCoord, rootElement }) => {
-  if (!tableContainerRef.current?.scrollTo || !rootElement) return;
+  if (!tableContainerRef.current.scrollTo) return;
 
   const [x, y] = focusedCellCoord;
   const tableHead = rootElement.getElementsByClassName('sn-table-head-cell')[0];
@@ -37,7 +37,7 @@ export const handleNavigateTop = ({ tableContainerRef, focusedCellCoord, rootEle
     const targetOffsetTop = tableContainerRef.current.scrollTop - cell.offsetHeight - tableHead.offsetHeight;
     tableContainerRef.current.scrollTo({
       top: Math.max(0, targetOffsetTop),
-      behavior: 'smooth',
+      behavior: 'instant',
     });
   }
 };