This repository was archived by the owner on Mar 19, 2024. It is now read-only.
feat: evaluate expression at runtime #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ec05a6 to
128704c
Compare
cbt1
reviewed
Feb 2, 2024
| const properties = await model.getProperties(); | ||
| for (let i = 0; i < actionCallList.length; i++) { | ||
| const overrideValue = | ||
| properties.actions[i].value?.qStringExpression?.qExpr && |
There was a problem hiding this comment.
I have no idea what actionCallList does but, do note that overrideValue can become any falsy value. For example if qExpr === '', overrideValue becomes an empty string.
Same for overrideVariable.
There was a problem hiding this comment.
Is actions a required property on properties?
There was a problem hiding this comment.
And does it always match the length of actionCallList?
There was a problem hiding this comment.
That is a couple of questions. In order:
- ActionCallList is the list of actions that need to run. Actions from actions get pushed into this array if they are found. Good catch. I'll look at that
- Yes it is.
- It does not have to match actually. Since we first try to find the actions from a list the actionCallList might be shorter than actions. This could happen if you create the button through the api. It also makes sure it is backwards compatible. Most important though is probably conversion from the old button. There are some actions that we do not support in the new if I remember correct
There was a problem hiding this comment.
Fixed based on suggestion from Max. Also made sure that the actionCallList and actions list have the same length
haxxmaxx
reviewed
Feb 2, 2024
Co-authored-by: Max Gefvert <max.gefvert@qlik.com>
cbt1
approved these changes
Feb 2, 2024
haxxmaxx
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an options to have expression evaluate at runtime:
When this option is set the actions will run in order, but instead of using the expression values from the layout the expressions will be evaluated just before the action is run. This means that previous actions can impact the state for the next actions.