[QOLCHG-774] Remove index.properties on restore … #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig is used as default "index" folder is already hardcoded
ThrawnCA
approved these changes
Oct 29, 2024
duttonw
reviewed
Oct 30, 2024
| @@ -276,6 +276,8 @@ | |||
| # If not, then it's either a directory (obsolete) or malformed, so ignore it. | |||
| if (tar tzf "$LATEST_INDEX" >/dev/null 2>&1); then | |||
| mkdir -p "$CORE_DATA/index" | |||
| # remove the index.properties file so default index config is used | |||
| rm -f $CORE_DATA/index.properties | |||
There was a problem hiding this comment.
hmm, need to read up on solr docs if this is needed or should be configured in its properties
https://solr.apache.org/docs/7_0_1/solr-core/org/apache/solr/core/SolrCore.html#getNewIndexDir--
solr docker container build also -
https://github.com/ckan/ckan-solr/blob/solr-9/solr-9/Dockerfile
https://github.com/apache/solr-docker/blob/cabde2a16c99aa974e1882df2c55ca17eab0bd17/9.7/Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so default index config is used as default "index" folder is already hardcoded