Fix circuit ordering in InterleavedRB #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the circuit order can be an experiment option defaulting to RIRIRI that can be optionally set upon experiment instantiation as well, what do you think? |
|
That makes sense to me. BTW. I'm understanding Qiskit Experiments has a convention that all experiment options can be set upon experiment instantiation. Is it correct? |
coruscating
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
This looks good to me, thanks! The current convention is that options can be and are usually set upon instantiation, but it might be worth formalizing the rules on when exactly options (and the backend) can be specified with the planned refactoring of the workflow.
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
### Summary Changes the ordering of circuits generated by `InterleavedRB` back to RIRIRI (R: Reference, I: Interleaved) order. It was accidentally changed into RRRIII order in #898. Before that, it had been RIRIRI order. ### Details and comments This change may slightly alter the impact of noise on IRB results. RIRIRI ordering is preferable in the sense that it minimizes the impact of drift or noise fluctuations. Note that `InterleavedRBAnalysis` is not changed that means it works correctly regardless of the circuit ordering because it processes data relying on "interleaved" flag in circuit metadata. This commit also adds a new experiment option `circuit_order` to `InterleavedRB`. It enables to change the order of the reference and the interleaved circuits and hence slightly alter the impact of noise on interleaved RB results. The default value is set to `"RIRIRI"`. (cherry picked from commit c6753f3)
coruscating
added a commit
that referenced
this pull request
Jun 29, 2023
This is an automatic backport of pull request #1191 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Toshinari Itoko <15028342+itoko@users.noreply.github.com> Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the ordering of circuits generated by
InterleavedRBback to RIRIRI (R: Reference, I: Interleaved) order. It was accidentally changed into RRRIII order in #898. Before that, it had been RIRIRI order.Details and comments
This change may slightly alter the impact of noise on IRB results. RIRIRI ordering is preferable in the sense that it minimizes the impact of drift or noise fluctuations. Note that
InterleavedRBAnalysisis not changed that means it works correctly regardless of the circuit ordering because it processes data relying on "interleaved" flag in circuit metadata.This commit also adds a new experiment option
circuit_ordertoInterleavedRB. It enables to change the order of the reference and the interleaved circuits and hence slightly alter the impact of noise on interleaved RB results. The default value is set to"RIRIRI".