Fix MarkerStyle for matplotlib compatibility (backport #1113) #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this single change allows qiskit_experiments to work for matplotlib 3.7
```
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/__init__.py:68: in <module>
from . import library
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/library/__init__.py:116: in <module>
from .calibration import (
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/library/calibration/__init__.py:62: in <module>
from .rough_frequency import RoughFrequencyCal
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/library/calibration/rough_frequency.py:20: in <module>
from qiskit_experiments.library.characterization.qubit_spectroscopy import QubitSpectroscopy
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/library/characterization/__init__.py:79: in <module>
from .analysis import (
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/library/characterization/analysis/__init__.py:15: in <module>
from .drag_analysis import DragCalAnalysis
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/library/characterization/analysis/drag_analysis.py:20: in <module>
import qiskit_experiments.curve_analysis as curve
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/curve_analysis/__init__.py:553: in <module>
from .base_curve_analysis import BaseCurveAnalysis
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/curve_analysis/base_curve_analysis.py:31: in <module>
from qiskit_experiments.visualization import (
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/visualization/__init__.py:71: in <module>
from .drawers import BaseDrawer, LegacyCurveCompatDrawer, MplDrawer
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/visualization/drawers/__init__.py:15: in <module>
from .legacy_curve_compat_drawer import LegacyCurveCompatDrawer
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/visualization/drawers/legacy_curve_compat_drawer.py:20: in <module>
from qiskit_experiments.curve_analysis.visualization import BaseCurveDrawer
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/curve_analysis/visualization/__init__.py:25: in <module>
from .mpl_drawer import MplCurveDrawer
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/curve_analysis/visualization/mpl_drawer.py:36: in <module>
class MplCurveDrawer(BaseCurveDrawer):
venvs/s/581f024a/venv/lib/python3.9/site-packages/qiskit_experiments/curve_analysis/visualization/mpl_drawer.py:39: in MplCurveDrawer
DefaultMarkers = MarkerStyle().filled_markers
venvs/s/581f024a/venv/lib/python3.9/site-packages/matplotlib/markers.py:261: in __init__
_api.warn_deprecated(
venvs/s/581f024a/venv/lib/python3.9/site-packages/matplotlib/_api/deprecation.py:96: in warn_deprecated
warn_external(warning, category=MatplotlibDeprecationWarning)
venvs/s/581f024a/venv/lib/python3.9/site-packages/matplotlib/_api/__init__.py:388: in warn_external
warnings.warn(message, category, stacklevel)
E matplotlib._api.deprecation.MatplotlibDeprecationWarning: Calling MarkerStyle() with no parameters is deprecated since 3.6; support will be removed two minor releases later. Use MarkerStyle('') to construct an empty MarkerStyle.
```
### Summary
matplotlib API changes in 3.7
### Details and comments
Some details that should be in this section include:
qiskit_experiments has a warning if this change it not made.
- E matplotlib._api.deprecation.MatplotlibDeprecationWarning: Calling
MarkerStyle() with no parameters is deprecated since 3.6; support will
be removed two minor releases later. Use MarkerStyle('') to construct an
empty MarkerStyle.
### PR checklist (delete when all criteria are met)
- [X] I have read the contributing guide `CONTRIBUTING.md`.
- [X] I have added the tests to cover my changes.
- [X] I have updated the documentation accordingly.
- [X] I have added a release note file using `reno` if this change needs
to be documented in the release notes.
---------
Co-authored-by: Helena Zhang <hadron.diaspora@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Helena Zhang <helena.zhang@ibm.com>
(cherry picked from commit 7a1fb78)
coruscating
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1113 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com