Adding state shape preservation to Solver.solve #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brosand
reviewed
Apr 27, 2022
chriseclectic
approved these changes
Apr 29, 2022
brosand
approved these changes
May 4, 2022
donsano33
pushed a commit
to donsano33/qiskit-dynamics
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #96
Resolves the issue raised in discussion #95
Solver.solverespects input state type in the sense that ify0is a quantum info type, then the returned solution is wrapped in the same class. However, as pointed out in discussion #95, the dimension data ofy0was not preserved when wrapping the solutions. This PR ensures updatesSolver.solveto fix this.Details and comments
The state type handling in
Solver.solveis handled byinitial_state_converterandfinal_state_converter. This PR updatesinitial_state_converterto also return awrapperfunction to call to wrap the final states. Thiswrapperfunction is setup to include any additional kwargs needed beyond the array at construction - in this case dimension data. The functionfinal_state_converteris removed as it is now redundant.A test is also added to verify correct behaviour for various input types.