Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NumPy 2.x #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gsamsonidze
Copy link

Summary

The current code does not work with NumPy 2.x because importing float_ fails. This PR replaces float_ with float64, which is an alias for float_ and is present in both NumPy 1.x and NumPy 2.x.

Details and comments

  • The current tests cover my changes. One test currently fails with or without my changes.
  • The documentation does not specify the NumPy version.
  • I have read the CONTRIBUTING document.

@gsamsonidze gsamsonidze requested a review from a team as a code owner August 21, 2024 15:09
@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants