-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect expectation values for the identity observable #58
Comments
Thanks for reporting this @mberna, read below for my initial assessment (c.c. @1ucian0). Note Because of the nature of this issue, it is very limited in scope and unlikely to affect anything other than trivial computations or misuses of the tool (e.g. to mitigate errors on a zero-noise/ideal simulator and under especial circumstances). Observations
Next steps
Please, let me know if you agree to this and I will proceed. |
I would prioritize this step over the other two. The rest sounds good to me. |
<!--⚠️ If you do not respect this template, your pull request will be closed.⚠️ Your pull request title should be short detailed and understandable for all.⚠️ Also, please add a release note file using reno if the change needs to be documented in the release notes.⚠️ If your pull request fixes an open issue, please link to the issue. - [ ] I have added the tests to cover my changes. - [ ] I have updated the documentation accordingly. - [ ] I have read the CONTRIBUTING document. --> ### Summary Adds support for zero variance inputs in `OLSExtrapolator` and classes implementing such interface. ### Details and comments Builds towards solving issue #58
<!--⚠️ If you do not respect this template, your pull request will be closed.⚠️ Your pull request title should be short detailed and understandable for all.⚠️ Also, please add a release note file using reno if the change needs to be documented in the release notes.⚠️ If your pull request fixes an open issue, please link to the issue. - [ ] I have added the tests to cover my changes. - [ ] I have updated the documentation accordingly. - [ ] I have read the CONTRIBUTING document. --> ### Summary Add new `MultiQubitAmplifier` facade to perform noise amplification on all multi-qubit gates. ### Details and comments Builds towards solving issue #58
<!--⚠️ If you do not respect this template, your pull request will be closed.⚠️ Your pull request title should be short detailed and understandable for all.⚠️ Also, please add a release note file using reno if the change needs to be documented in the release notes.⚠️ If your pull request fixes an open issue, please link to the issue. - [ ] I have added the tests to cover my changes. - [ ] I have updated the documentation accordingly. - [ ] I have read the CONTRIBUTING document. --> ### Summary Update default amplifier in `ZNEStrategy` to act on all multi-qubit gates (i.e. `MultiQubitAmplifier`) instead of just two-qubit gates (i.e. `TwoQubitAmplifier`). ### Details and comments Builds towards solving #58
Device
MacBook Pro
OS
macOS Sonoma 14.0
Python version
3.11.7
Release version or branch/commit
1.2.2
What is the current behavior?
The expectation values returned by the ZNEEstimator are not correct for this particular example. I'm including the results of the "reference implementation" of the Estimator in
qiskit.primitives
and the exp values differ greatly.What is the expected behavior?
Expectation values return by the ZNEEstimator are similar to the reference implementation.
Steps to reproduce the problem
Context
Tested this example with different versions of the library and the
1.0.0
was the last version that produced correct results.Suggestions
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: