This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Adaptive QRAC #12
Draft
Adaptive QRAC #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11
before, we'd index an array which would do this implicitly.
I added a high-level statistical test of magic rounding in 0ed7382, and this test fails on this branch, as expected. 👍 |
|
The main thing left to do here is to remove the following assumption, which is used throughout the magic rounding code: prototype-qrao/qrao/rounding_common.py Line 61 in bb6bd61 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11. This may require some additional cleanup/comments in the code. And it should not be merged until the following issue is closed:
Also, as part of this we should add a test case that will only pass once #7 is fixed. It is a bit concerning that all tests pass currently, even though we know there'd be an obvious problem if we were to merge this immediately.
Details and comments