Skip to content

Commit

Permalink
Feature: Add a tooltip to the runs table experiment name column (tens…
Browse files Browse the repository at this point in the history
…orflow#6097)

## Motivation for features / changes
For Googlers b/259431435
We abbreviate the name of the experiment which can lead to confusion. By
showing the full name in a tooltip we provide users a way of accessing
that information.

## Technical description of changes
Tooltips are generally created by setting the `title` attribute.
However, this particular column is a custom element and thus required me
to pass the attribute through.

## Screenshots of UI changes
IDK how to screenshot tooltips 🤷 

## Detailed steps to verify changes work correctly (as executed by you)
I tested this on internal tensorboard where the experiment column gets
used.
  • Loading branch information
rileyajones authored and qihach64 committed Dec 19, 2022
1 parent 9900ece commit 37c9de5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@
<tb-experiment-alias
*ngSwitchCase="RunsTableColumn.EXPERIMENT_NAME"
[alias]="item.experimentAlias"
[title]="item.experimentName"
></tb-experiment-alias>

<span *ngSwitchCase="RunsTableColumn.RUN_NAME" class="name"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ import {ExperimentAlias} from '../../experiments/types';
(onValueChange)="aliasChanged.emit($event)"
></content-wrapping-input>
<ng-template #noEditAliasName>
<span [class.illegal]="!isAliasNameLegal">{{ alias.aliasText }}</span>
<span [class.illegal]="!isAliasNameLegal" [title]="title">{{
alias.aliasText
}}</span>
</ng-template>
`,
styleUrls: [`experiment_alias_component.css`],
Expand All @@ -43,6 +45,9 @@ export class ExperimentAliasComponent {
@Input()
aliasEditable!: boolean;

@Input()
title?: string;

@Input()
isAliasNameLegal: boolean = true;

Expand Down

0 comments on commit 37c9de5

Please sign in to comment.