Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix json: declare from_json_impl function definitions in advance when… #326

Conversation

fesily
Copy link

@fesily fesily commented Nov 19, 2024

… variant

@fesily fesily force-pushed the fix-json--declare-from_json_impl-definitions-in-advance-when-variant branch from 23b5f27 to b373215 Compare November 19, 2024 03:09
@qicosmos
Copy link
Owner

用clang-format-13 格式化一下代码先。

@qicosmos
Copy link
Owner

这个代码格式变动太多了。
image
这样我没法看代码差异,先恢复一下代码,只格式化修改的代码吧。

@fesily fesily force-pushed the fix-json--declare-from_json_impl-definitions-in-advance-when-variant branch from 4027961 to 0a084ca Compare November 19, 2024 03:31
@qicosmos qicosmos self-requested a review November 19, 2024 03:37
Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit 46ab4d8 into qicosmos:master Nov 19, 2024
18 checks passed
@fesily fesily deleted the fix-json--declare-from_json_impl-definitions-in-advance-when-variant branch November 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants