-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform specific Readme #187
Conversation
I like the simplicity of using Mermaid, and letting it do whatever prefers. However, I checked the Mermaid docs, and they do not have any actual graph drawing class, so for large chips it may be doing a terrible job... (which is not a big deal right now) For this PR, just using Mermaid is more than fine. But, as I said, these are ideas for later on. Right now is fine as it is, and incredibly nice in it's minimal implementation. Thanks :) |
Yeah indeed for the 11q is not working great: graph TD;
A1 <--> A2;
A1 <--> A3;
A1 <--> D5;
A2 <--> A4;
A2 <--> A6;
A3 <--> A4;
A3 <--> D4;
A4 <--> A5;
A4 <--> B3;
A5 <--> B1;
A6 <--> B3;
A6 <--> D3;
B1 <--> B2;
B1 <--> B3;
B2 <--> B4;
B3 <--> B4;
B4 <--> B5;
D1 <--> D2;
D1 <--> D3;
D2 <--> D4;
D3 <--> D4;
D4 <--> D5;
I tried to look for alternative layout algorithm but I couldn't find much information... |
Well, it's not ideal, but not even that bad. It's a bit entangled, but you get all the information you need. |
@BrunoLiegiBastonLiegi I'd discourage you to go through the workflows' README generation, for two main reasons:
Instead, what you could do is to check in the workflow if any platform is lacking a README, and then publish a message on the PR suggesting providing such a README, and a good starting point may be achieved by running the script for that platform. |
If you are changing the configuration of one or more platforms remember to run |
Ok this should be more or less ready, the only thing I am not completely sure about concerns the native gates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I didn't go through the whole script, and it's brief enough that is not worth optimizing that much...
But here are just a few technical and qualitative simplifications.
Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
Could we use this PR to add the installation requirements in the READMEs qiboteam/qibocal#988 (comment) ? |
Manually yes (with the script is overly complicated, for little to no advantage...). Or even a PR on top of this one is also fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last ones were just stylistic suggestions. To me, it's good to merge.
Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
@BrunoLiegiBastonLiegi could you please fix the test issue? |
Not sure the error is related to this PR specifically. Even #180 was failing for the same reason. |
No, you're not supposed to fix that error. But the problem is not 0.2, but rather the OPX1000. The stable workflow is testing with the latest release, and the 0.1 driver for the OPX1000 is yet unreleased (in 0.1, while it has been just released for 0.2). Instead, the driver is merged in the So, the workflows should be fine as they are. |
You depend very mildly on the format of qibolab_platforms_qrc/generate_readme.py Line 21 in be32893
none of these keys is any longer present. Now, you should extract the qibolab_platforms_qrc/qw11q/parameters.json Lines 183 to 185 in b2f6b35
while the nqubits will be just len(qubits) . And analogously with the topology , that is derived from the available two-qubit gatesqibolab_platforms_qrc/qw11q/parameters.json Lines 387 to 388 in b2f6b35
(you may consider just loading the platform, executing the |
@BrunoLiegiBastonLiegi please let us know when this is ready so we can merge to main and them include this in #191. |
This is ready, but it's not going to be merged in main, rather in |
Even #191 will be merged in |
This PR adds a small script to parse the
parameters.json
file and generate aREADME.md
with some basic information for each platform.For instance, for
qw5q_platinum
:qw5q_platinum
Native Gates
Single Qubit: RX, RX12, MZ
Two Qubit: CZ
Topology
Number of qubits: 5
Qubits: [0, 1, 2, 3, 4]