Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop offset setting Qblox #104

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Drop offset setting Qblox #104

merged 6 commits into from
Jan 15, 2024

Conversation

PiergiorgioButtarini
Copy link
Contributor

This PR is needed after merging qiboteam/qibolab#686.

The offset setting, regarding modules Qcm_bb, was removed from the runcard yaml since this information is already provided by qubit.sweetspot.

@alecandido
Copy link
Member

Don't you need to remove also:

qcm_bb0:
o1:
offset: 0.0
o2:
offset: 0.0
o3:
offset: 0.0
o4:
offset: 0.0
qcm_bb1:
o1:
offset: 0.0
o2:
offset: 0.0
o3:
offset: 0.0
o4:
offset: 0.0
qcm_bb2:
o1:
offset: 0.0
o2:
offset: 0.0

?

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to remove also:

Done. We should merge this asap, otherwise qblox does not work with the current main of qibolab.

@PiergiorgioButtarini
Copy link
Contributor Author

Thanks @stavros11! Sorry @alecandido I was in the lab and I forgot to address your comment.

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stavros11! Sorry @alecandido I was in the lab and I forgot to address your comment.

Never mind :)

@stavros11 stavros11 merged commit 196bd5d into main Jan 15, 2024
1 of 2 checks passed
@stavros11 stavros11 deleted the remove_offset branch January 15, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants