-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop offset setting Qblox #104
Conversation
Don't you need to remove also: qibolab_platforms_qrc/spinq10q.yml Lines 79 to 101 in bddae91
? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to remove also:
Done. We should merge this asap, otherwise qblox does not work with the current main of qibolab.
Thanks @stavros11! Sorry @alecandido I was in the lab and I forgot to address your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stavros11! Sorry @alecandido I was in the lab and I forgot to address your comment.
Never mind :)
This PR is needed after merging qiboteam/qibolab#686.
The offset setting, regarding modules Qcm_bb, was removed from the runcard yaml since this information is already provided by
qubit.sweetspot
.