Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to client #9

Merged
merged 34 commits into from
Dec 15, 2023
Merged

Add unit tests to client #9

merged 34 commits into from
Dec 15, 2023

Conversation

marcorossi5
Copy link
Contributor

No description provided.

@marcorossi5 marcorossi5 self-assigned this Dec 13, 2023
@marcorossi5 marcorossi5 marked this pull request as draft December 13, 2023 12:35
@marcorossi5 marcorossi5 marked this pull request as ready for review December 14, 2023 14:16
@marcorossi5
Copy link
Contributor Author

@scarrazza, I've added the workflow to publish on pypi. We should put the secret in the PYPI_TOKEN variable. I'm afraid I do not have permissions to do that.

After that, I think we can merge

@scarrazza
Copy link
Member

@marcorossi5 could you please use the approach in qibo? We have a repository with workflows, please double check.

@marcorossi5
Copy link
Contributor Author

@scarrazza, it should be done now, but the workflow is failing at the codecov stage due to a missing token. Do we have to update the repo secrets for that?

Copy link

codecov bot commented Dec 15, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@scarrazza
Copy link
Member

Thanks @marcorossi5, now this repo is public and I have activated codecov and precommit.

@scarrazza
Copy link
Member

@marcorossi5 just another couple of requests:

  • could you please replace in all places TiiQ with TII-QRC?
  • I think it would be useful to include some technical docs explaining how to use this library and the content of the library. For example a simple sphinx page, with installation instructions, a short tutorial and the api reference should be sufficient. Could you please grab the setup in qibo* and try to port here, maybe in another PR?

@marcorossi5
Copy link
Contributor Author

Let me replace TiiQ with TII-QRC. Then, if you agree, we can merge and open a new PR to address the second point.

Do you want to keep TIIProvider as the client class name? or do you want me to change it?

@scarrazza
Copy link
Member

Great, thanks. I think we can keep TIIProvider for now.

@marcorossi5
Copy link
Contributor Author

What about the package name? qibo_tii_provider still works?

@scarrazza
Copy link
Member

Let me think but meanwhile let's keep as it is. I just prefer to avoid using TiiQ in the docs.

@marcorossi5 marcorossi5 merged commit f577686 into main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants