-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client does not hang #42
Conversation
for more information, see https://pre-commit.ci
…to feature/client-does-not-hang
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 7 +2
Lines 117 199 +82
=========================================
+ Hits 117 199 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is missing a function which downloads the results from the server: r = client.get_results(pid=''') |
for more information, see https://pre-commit.ci
…to feature/client-does-not-hang
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…to feature/client-does-not-hang
@marcorossi5 could you please include the following changes too:
|
@scarrazza, coverage is 100% now. Can you merge? |
@marcorossi5, do we have a |
Not yet. It can be useful. Let me implement it in a separate branch after we merge these two if you agree |
ok, thanks. |
src/qibo_client/qibo_job.py
Outdated
ERROR = "error" | ||
|
||
|
||
def wait_for_response_to_get_request( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need this function outside the QiboJob
class? If you move there as a private function _wait_for_response...
you can access the status and avoid all the problems raised in the discussion above.
This PR adds a
wait_for_results
boolean flag toClient.run_circuit
method to let the user choose if the client should hang or not waiting for the server returning the results.