Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client does not hang #42

Merged
merged 34 commits into from
Aug 2, 2024
Merged

Client does not hang #42

merged 34 commits into from
Aug 2, 2024

Conversation

marcorossi5
Copy link
Contributor

This PR adds a wait_for_results boolean flag to Client.run_circuit method to let the user choose if the client should hang or not waiting for the server returning the results.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2e358ef) to head (cfbdb01).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         7    +2     
  Lines          117       199   +82     
=========================================
+ Hits           117       199   +82     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza scarrazza marked this pull request as draft June 28, 2024 20:12
@scarrazza
Copy link
Member

This is missing a function which downloads the results from the server:

r = client.get_results(pid=''')

@marcorossi5
Copy link
Contributor Author

This new commit implements the Qiskit-like interface of QiboClient and tests.

Address #22, #41, #46, #49

@marcorossi5 marcorossi5 marked this pull request as ready for review July 19, 2024 13:54
@scarrazza
Copy link
Member

@marcorossi5 could you please include the following changes too:

@marcorossi5
Copy link
Contributor Author

@scarrazza, coverage is 100% now. Can you merge?

@scarrazza
Copy link
Member

@marcorossi5, do we have a client.get_job(jobid) or similar function?

@marcorossi5
Copy link
Contributor Author

marcorossi5 commented Jul 29, 2024

Not yet. It can be useful. Let me implement it in a separate branch after we merge these two if you agree

@scarrazza
Copy link
Member

ok, thanks.

ERROR = "error"


def wait_for_response_to_get_request(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this function outside the QiboJob class? If you move there as a private function _wait_for_response... you can access the status and avoid all the problems raised in the discussion above.

@scarrazza scarrazza merged commit e090fea into main Aug 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants