-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postpone environment evaluation #30
Conversation
Btw, you're mixing Line 1 in 4e70c04
(and Pytest is the runner). I'd suggest using https://docs.pytest.org/en/latest/how-to/monkeypatch.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 121 125 +4
=========================================
+ Hits 121 125 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine by me, even though from a practical perspective it is very unlikely that we will need this feature when we will have a stable setup.
Hopefully true, but it could happen that someone wants to patch the port after import (that almost always happens top-level). True that, since the port is fixed server-side, there should be no reason to patch the provider. But it is also useful as a blueprint for other ones (and it should not be harmful). |
Let's merge for the moment and open a refactoring issue about that. |
At the moment, I shifted this to the
Client()
instantiation.It could be better to pass down the callable, and only retrieve the URL during the request.
I didn't do it, because there might be a point in having a consistent
Client
, during its whole lifetime (though I'm not sure...).Closes #29