Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash opening features with lots of xlink:href #19

Closed
JPPauly opened this issue May 19, 2020 · 5 comments
Closed

Crash opening features with lots of xlink:href #19

JPPauly opened this issue May 19, 2020 · 5 comments

Comments

@JPPauly
Copy link
Contributor

JPPauly commented May 19, 2020

Hello,
on loading features with lots of xlink:href elements with the resolve option activated, f.e. from INSPIRE AU.AdministrativeUnits, QGIS3 crashes.

Example-service that leads to crashes on loading AdministrativeUnits: https://www.geodaten-mv.de/dienste/inspire_au_atkis_bdlm_download

I found a solution by changing the line 1010 in wfsclientdialog.py to: gdal.SetConfigOption('GML_SKIP_RESOLVE_ELEMS', 'HUGE')
@ejn
Copy link
Contributor

ejn commented May 19, 2020

Thanks for the report. Looking at https://gdal.org/drivers/vector/gml.html#gml-xlink-resolving then setting GML_SKIP_RESOLVE_ELEMS to HUGE should work in all cases.

I wonder whether there any disadvantages to it? I guess a slight overhead in saving resolved objects to DB rather than keeping them in memory, but any others?

Maybe it would be better to allow the user to choose between ALL, HUGE AND NONE in the configuration dialog in case there are some special cases where one or the other is necessary?

@ejn
Copy link
Contributor

ejn commented May 28, 2020

It seems that there are no disadvantages to using HUGE (source), so I'll just change it as you suggest.

ejn added a commit that referenced this issue May 29, 2020
@ejn
Allow opening features with lots of xlink:href
d15372f 
 * Use HUGE instead of NONE for GDAL option GML_SKIP_RESOLVE_ELEMS

See #19
@JPPauly
Copy link
Contributor Author

JPPauly commented Apr 12, 2021

Thank you for fixing the issue.

Are there any plans to deploy those fixes to the QGIS Plugin repository's version of the plugin? That would make rollout easier in our organisation.

@ejn
Copy link
Contributor

ejn commented Apr 14, 2021

@JPPauly Thanks for the feedback. To be honest I'd completely forgotten that this hadn't been done - I'll see to it, that the repo version gets updated and close this ticket once it's done.

@ejn
Copy link
Contributor

ejn commented Apr 15, 2021

Plugin version 0.9.10 is now published and approved in the QGIS Plugins repository.

@ejn ejn closed this as completed Apr 15, 2021
@ejn ejn mentioned this issue Feb 2, 2022
Open
ejn added a commit to ejn/qgis-wfs20-client-plugin that referenced this issue Aug 3, 2022
@ejn
feature: Enable user-side configuration of xlink:href resolving
d332291 
 * Due to qgisinspiretools#19 the GDAL-configuration GML_SKIP_RESOLVE_ELEMS was set to HUGE
   when the user requests resolving of xlink:href (previously NONE).
 * This change is presumably the reason for problems reported resolving in qgisinspiretools#25.
 * Since probably not everyone will be satisified with one or other of the
   options then the user should be able to choose which to use once
   resolving of xlink:href is activated, thus removing the need for the devloper
   to decide which option to use and passing this decision to the user.
 * The default GML_SKIP_RESOLVE_ELEMS is maintained as HUGE.
@ejn ejn mentioned this issue Aug 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejn @JPPauly