Fix artifacts when rendering filled line symbol (backport) #60578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overload avoids creating a QgsGeometry if we only have a QgsAbstractGeometry pointer object to convert (cherry picked from commit 97f6dc5)
(cherry picked from commit 649dc29)
These methods directly work with GEOS geometries and avoid the forced conversions to/from QgsAbstractGeometry objects, and are intended for use in chained operations where the intermediate conversions are not required. (cherry picked from commit ecf57ef)
Use geos to calculate the buffered line instead of Qt's path stroker, as the later results in artifacts when line segments pass close to other segments Fixes qgis#59689 (cherry picked from commit f0110d6)
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nirvn
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #60554