Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui][diagrams] Fix drag and drop to reorder stacked diagram not working #60278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jan 27, 2025

Description

This PR fixes #59505 whereas the stacked diagrams tree view was not allowing for drag and drop re-ordering of sub-diagrams. It's an important UI/UX that users would definitively expect here as we allow for drag and drop re-ordering for symbology renderers and rule-based label renderer widgets.

In addition, while fixing this, I've harmonized the tree view by removing the "Enabled" column in favor of adding a checkbox in the first column where the diagram name is located (like we do pretty much everywhere else), as well as adding a nice touch of night mapping (eye toggles!).

Screenshot From 2025-01-27 09-43-45

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 0b09072)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 0b09072)

@DelazJ
Copy link
Contributor

DelazJ commented Jan 27, 2025

Thanks @nirvn
One point raised in the issue report I can't tell if covered here is the handling of sub-diagram placement settings. Per the initial PR:

Note there are some shared settings like placement settings (e.g., over point), that the stacked diagram will take from its first subdiagram. Thus, other subdiagrams won't be able to set or change those specific settings, unless they become the first subdiagram in the stacked diagram. Therefore, when editing a subdiagram that is not located in the first place, we show labels to let users know why they don't see the expected widgets (e.g., placement ones) and where they can find them (i.e., in the first subdiagram).

Some options of subdiagrams not topmost are currently greyed out. My suggestion was to allow any diagram options to be modified anytime, regardless the rank of the subdiagram, and then have a method that would apply only placement options from the topmost to the whole stack. That way, a simple-drag-and-drop would be enough to preview what I expect, and not require subsequent placement options modifications. And if I switch again the order...?
Better have the subdiagram options set when I'm configuring the subdiagram, once for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reorder subdiagrams in stacked diagrams dialog
3 participants